hydra
hydra copied to clipboard
feat: extend latest and session related consents
This pull request introduces feature to extend consent validity time for both session related consent and subject related consent. Currently consent validity cannot be updated (when skip=true) or to be more precise - consent updates only if new device/browser accepts consent.
Checklist
- [x] I have read the contributing guidelines.
- [x] I have referenced an issue containing the design document if my change introduces a new feature.
- [x] I am following the contributing code guidelines.
- [x] I have read the security policy.
- [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security. vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
- [x] I have added tests that prove my fix is effective or that my feature works.
- [x] I have added or changed the documentation.
Codecov Report
Merging #3043 (313256f) into master (3b1d87e) will increase coverage by
0.31%. The diff coverage is92.65%.
:exclamation: Current head 313256f differs from pull request most recent head e6963be. Consider uploading reports for the commit e6963be to get more accurate results
@@ Coverage Diff @@
## master #3043 +/- ##
==========================================
+ Coverage 76.85% 77.16% +0.31%
==========================================
Files 124 124
Lines 9162 9348 +186
==========================================
+ Hits 7041 7213 +172
- Misses 1672 1680 +8
- Partials 449 455 +6
| Impacted Files | Coverage Δ | |
|---|---|---|
| consent/manager.go | 100.00% <ø> (ø) |
|
| consent/handler.go | 66.45% <50.00%> (-0.32%) |
:arrow_down: |
| persistence/sql/persister_consent.go | 86.98% <83.87%> (-0.44%) |
:arrow_down: |
| consent/manager_test_helpers.go | 98.18% <100.00%> (+0.25%) |
:arrow_up: |
... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.