hydra-maester icon indicating copy to clipboard operation
hydra-maester copied to clipboard

Allow user defined client IDs

Open tokongs opened this issue 1 year ago • 2 comments

Preflight checklist

Ory Network Project

No response

Describe your problem

When creating a Oauth2Client with an secret that contains a predefined CLIENT_ID. The reconciliation errors out because it's unable to find a client with that ID.

Describe your ideal solution

A client with the provided ID is created.

Workarounds or alternatives

None

Version

0.34.0

Additional Context

No response

tokongs avatar Oct 29 '24 11:10 tokongs

I can confirm this, and I'd like to add that this is a regression because this used to work with older versions of hydra-maester. We're relying on this behaviour to have predictable client IDs and secrets that we can set using our provisioning system, so this change in behaviour is preventing us from upgrading hydra.

ariep avatar Dec 17 '24 16:12 ariep

From a quick reading, this seems to be the commit that introduced this change: https://github.com/ory/hydra-maester/commit/2a6cef500680b4c5c85e6ad4af28545b4ce5d23e#diff-1c66e5dad42957f87587a8ad18d9815b912a40e6bbacb41d64be576d56a92750R204

Oh I think this is a duplicate of #117 though.

ariep avatar Dec 17 '24 16:12 ariep