fosite icon indicating copy to clipboard operation
fosite copied to clipboard

Why does HMACStrategy.Generate uses a lock?

Open mitar opened this issue 5 months ago • 3 comments

Preflight checklist

Ory Network Project

No response

Describe the bug

While reading the code, I noticed that HMACStrategy.Generate uses a mutex lock, but I do not get why it exists. No code there has any global or local state?

This was introduced in https://github.com/ory/fosite/commit/b4b9be5640c9d814b35f54b2c8621137364209ca, but I also do not get why.

Given that this is used a lot, I think mutex could be removed?

Reproducing the bug

N/A

Relevant log output

No response

Relevant configuration

No response

Version

latest master

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

mitar avatar Mar 10 '24 10:03 mitar