elements icon indicating copy to clipboard operation
elements copied to clipboard

feat: consent card with custom onSubmit

Open Benehiko opened this issue 2 years ago • 2 comments

Related Issue or Design Document

https://github.com/ory/elements/issues/110

Checklist

  • [ ] I have read the contributing guidelines and signed the CLA.
  • [ ] I have referenced an issue containing the design document if my change introduces a new feature.
  • [ ] I have read the security policy.
  • [ ] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added necessary documentation within the code base (if appropriate).

Further comments

Benehiko avatar Jul 04 '23 14:07 Benehiko

Do the changes in this PR need testing?

davidspek avatar Aug 09 '23 22:08 davidspek

yes, i haven't had time to complete it yet. It still requires a bit more e2e testing to make sure this works properly in the example nextjs application.

Benehiko avatar Aug 10 '23 09:08 Benehiko