docs icon indicating copy to clipboard operation
docs copied to clipboard

docs: nginx rewrite conflict with RedirectAdminMiddleware

Open Laplace-Transformer opened this issue 1 year ago • 3 comments

Removed removal of nginx rewrite. Conflicted with "RedirectAdminMiddleware" in the kratos code, which adds the prefix "admin/" if not present.

Related Issue or Design Document

Checklist

  • [x] I have read the contributing guidelines and signed the CLA.
  • [ ] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [x] I have added the necessary documentation within the code base (if appropriate).

Further comments

Laplace-Transformer avatar Nov 07 '24 12:11 Laplace-Transformer

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 07 '24 12:11 CLAassistant

To merge this we would probably need to run through this example step by step, unless there is a clear reason why this was in there for so long and noone ever noticed it / complained about it?

aeneasr avatar Nov 12 '24 09:11 aeneasr

Hi again. There was a breaking change back in 2022, that you introduced: https://github.com/ory/kratos/commit/8acb4cfaa61ef52619e889b8c862191c6b92e5eb

I don't think many people use this documentation. I've tried to follow it but I've had few hiccups on the way that I'm currently trying to correct.

Laplace-Transformer avatar Nov 13 '24 12:11 Laplace-Transformer