BuildAndRun functions do not support container names different from the repository name

[robertcankney]

Describe the bug

L329 in dockertest.go currently overwrites the values of RunOpts.Repository with the Name value for the container. This prevents BuildAndRunWithBuildOptions and any functions that call it from creating containers with a Name other than that of the repository, which in turn prevents multiple test packages from executing concurrently, as there is no way to set unique container names.

To Reproduce

Steps to reproduce the behavior:

Expected behavior

I'd expect repository to be honored if it is set - i.e. instead of

runOpts.Repository = runOpts.Name

, something like

if runOpts.Repository == "" {
    runOpts.Repository = runOpts.Name
}

Environment

• Version: github.com/ory/dockertest/[email protected]
• Environment: All.

Additional context

More than happy to cut a PR for this!

[robertcankney]

Happy to make this change if repo owners agree with it - if so, would be great to get access to create a PR with this change. Would be super useful for our use of the package.

[aeneasr]

Yes, please do :) Please ensure that we keep backwards compatibility though! :)

[github-actions[bot]]

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

• open a PR referencing and resolving the issue;
• leave a comment on it and discuss ideas on how you could contribute towards resolving it;
• leave a comment and describe in detail why this issue is critical for your use case;
• open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️