Handle non existing window.matchMedia
Proposed Changes
Handle window.matchMedia being undefined properly. This can happen when it's hard to mock environment (jest/jsdom) like done in d0262fd675f51d5262737ec1ec3fc0f481db776b.
This should be harmless.
Deploy Preview for oruga-documentation-preview ready!
| Name | Link |
|---|---|
| Latest commit | 9dae48f7e10ede0c535867d77a8a20311aef77bf |
| Latest deploy log | https://app.netlify.com/sites/oruga-documentation-preview/deploys/6331fa3146aa680009ef9755 |
| Deploy Preview | https://deploy-preview-400--oruga-documentation-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
And oruga-next?
Of course :see_no_evil:
@tcitworld you should remove ? char because the build doesn't work as you can see
Codecov Report
Base: 66.62% // Head: 66.62% // No change to project coverage :thumbsup:
Coverage data is based on head (
071ef28) compared to base (35431c0). Patch coverage: 100.00% of modified lines in pull request are covered.
:exclamation: Current head 071ef28 differs from pull request most recent head 9dae48f. Consider uploading reports for the commit 9dae48f to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #400 +/- ##
========================================
Coverage 66.62% 66.62%
========================================
Files 61 61
Lines 4366 4366
Branches 1147 1147
========================================
Hits 2909 2909
Misses 1357 1357
Partials 100 100
| Impacted Files | Coverage Ξ | |
|---|---|---|
| packages/oruga/src/utils/MatchMediaMixin.js | 88.23% <100.00%> (ΓΈ) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@tcitworld any news?