BoxLang icon indicating copy to clipboard operation
BoxLang copied to clipboard

Add stack monitor that fails fast if transformer does not yield a sufficient stack number size.

Open raphw opened this issue 1 year ago • 3 comments

To simplify debugging, each transformer's result should be validated to check if the created stack is equivalent with the requested result which should be an empty stack or a stack with size one. If the validation fails, one knows exactly which transformer did not create the expected result what should simplify locating the error.

raphw avatar Aug 26 '24 10:08 raphw

Test Results

 2 576 files  ±0   2 576 suites  ±0   13m 14s ⏱️ +46s  6 305 tests ±0   6 220 ✅ ±0   85 💤 ±0  0 ❌ ±0  25 392 runs  ±0  25 024 ✅ ±0  368 💤 ±0  0 ❌ ±0 

Results for commit 384e10c2. ± Comparison against base commit 84161804.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 26 '24 10:08 github-actions[bot]

@jbeers Does this need merged?

bdw429s avatar Sep 18 '24 03:09 bdw429s

Just fixed the formatting, but I would recommend to add this to allow for debugging on a more local level.

raphw avatar Sep 18 '24 06:09 raphw

Are we still going to add this, seems it has conflicts now?

lmajano avatar Nov 19 '24 11:11 lmajano

I think this could be valuable to have available if you suddenly encountered illegal byte code. It does not come with overhead, if deactivated, so I'd merge it in.

raphw avatar Nov 19 '24 21:11 raphw

@jbeers merge please

lmajano avatar Nov 21 '24 15:11 lmajano

@jbeers ping

lmajano avatar Nov 25 '24 18:11 lmajano