orocommerce icon indicating copy to clipboard operation
orocommerce copied to clipboard

Can't delete line item after disabling taxtation.

Open xgitxhubx opened this issue 6 years ago • 1 comments

Step to reproduce:

  1. Disable tax calculation: disable_tax

  2. Edit order, delete 1 line item, and save: screenshot from 2018-03-05 16-16-49

Stack Trace:


    in vendor/oro/commerce/src/Oro/Bundle/TaxBundle/Manager/TaxManager.php at line 251  -
            protected function throwExceptionIfTaxationDisabled()
            {
                if (!$this->settingsProvider->isEnabled()) {
                    throw new TaxationDisabledException();
                }
            }
        }
    at TaxManager ->throwExceptionIfTaxationDisabled ()
    in vendor/oro/commerce/src/Oro/Bundle/TaxBundle/Manager/TaxManager.php at line 145  +
    at TaxManager ->removeTax (object(OrderLineItem))
    in vendor/oro/commerce/src/Oro/Bundle/TaxBundle/Provider/BuiltInTaxProvider.php at line 103  +
    at BuiltInTaxProvider ->removeTax (object(OrderLineItem))
    in vendor/oro/commerce/src/Oro/Bundle/TaxBundle/EventListener/EntityTaxListener.php at line 134  +
    at EntityTaxListener ->preRemove (object(OrderLineItem), object(LifecycleEventArgs))
    in vendor/doctrine/orm/lib/Doctrine/ORM/Event/ListenersInvoker.php at line 112  +
    at ListenersInvoker ->invoke (object(ClassMetadata), 'preRemove', object(OrderLineItem), object(LifecycleEventArgs), '5')
    in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php at line 1760  +
    at UnitOfWork ->doRemove (object(OrderLineItem), array('0000000047126a6100000000325560d5' => object(OrderLineItem)))
    in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php at line 1716  +
    at UnitOfWork ->remove (object(OrderLineItem))
    in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php at line 363  +
    at UnitOfWork ->commit (null)
    in app/cache/dev/classes.php at line 7949  +
    at EntityManager ->flush (null)
    in app/cache/dev/classes.php at line 8328  +
    at OroEntityManager ->flush ()
    in vendor/oro/platform/src/Oro/Bundle/FormBundle/Form/Handler/FormHandler.php at line 84  +
    at FormHandler ->saveData (object(Order), object(Form))
    in vendor/oro/platform/src/Oro/Bundle/FormBundle/Form/Handler/FormHandler.php at line 61  +
    at FormHandler ->process (object(Order), object(Form), object(Request))
    in vendor/oro/platform/src/Oro/Bundle/FormBundle/Model/UpdateHandler.php at line 164  +
    at UpdateHandler ->saveForm (object(Form), object(Order))
    in vendor/oro/platform/src/Oro/Bundle/FormBundle/Model/UpdateHandler.php at line 98  +
    at UpdateHandler ->handleUpdate (object(Order), object(Form), object(Closure), object(Closure), 'Order has been saved', null, object(Closure))
    in vendor/oro/commerce/src/Oro/Bundle/OrderBundle/Controller/OrderController.php at line 181  +
    at OrderController ->update (object(Order), object(Request))
    in vendor/oro/commerce/src/Oro/Bundle/OrderBundle/Controller/OrderController.php at line 130  +
    at OrderController ->updateAction (object(Order), object(Request))
    in vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php at line 135  +
    at HttpKernel ->handleRaw (object(Request), '1')
    in vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php at line 57  +
    at HttpKernel ->handle (object(Request), '1', true)
    in vendor/symfony/symfony/src/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.php at line 67  +
    at ContainerAwareHttpKernel ->handle (object(Request), '1', true)
    in vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php at line 183  +
    at Kernel ->handle (object(Request))
    in web/app_dev.php at line 34  +

xgitxhubx avatar Mar 05 '18 09:03 xgitxhubx

Hello @xgitxhubx,

Thank you for reporting the issue!

Created an issue to fix (Internal ID - BB-13872)

vladimirseniuk avatar Mar 05 '18 10:03 vladimirseniuk