orochimaru icon indicating copy to clipboard operation
orochimaru copied to clipboard

Make the poseidon to be a separated package

Open chiro-hiro opened this issue 1 year ago • 2 comments

Poseidon circuit had been implemented here but we want to create a crate out of it. So please make it to be an independent crate.

https://github.com/orochi-network/orochimaru/tree/main/zkmemory/src/poseidon

chiro-hiro avatar Aug 01 '24 05:08 chiro-hiro

I'd like take this issue and also clarify a few question:

  1. What I understand is I need to make poseidon a separate package and I'd most possibly do it this way. Does this align with what you expect?
├── src/
│   ├── commitment/
│   ├── constraints/
│   ├── poseidon/
│   │   ├── mod.rs
│   │   ├── poseidon_constants.rs
│   │   └── poseidon_hash.rs
│   ├── base.rs
│   ├── config.rs
│   ├── error.rs
│   ├── lib.rs
│   └── machine.rs
├── poseidon_hash/  <-- Make a new directory 
│   ├── src/
│   │   └── lib.rs
│   │   ├── poseidon_constants.rs
│   │   └── poseidon_hash.rs
│   └── Cargo.toml
├── Cargo.toml
  1. There are some with visibility only to crate level pub (crate) const ROUND_CONSTANTS_FR If I make it a separate package, Is it okay to make these const variables public to external? namely, pub const ROUND_CONSTANTS_FR

nooma-42 avatar Aug 02 '24 09:08 nooma-42

Please move on with this 👍

chiro-hiro avatar Aug 02 '24 09:08 chiro-hiro

closed by #77

nooma-42 avatar Aug 22 '24 11:08 nooma-42