ADIOS2 icon indicating copy to clipboard operation
ADIOS2 copied to clipboard

Published 20 hours ago • verified publisher icon ornladios

Enable WriteRead*MissingPerformGets` tests

Open vicentebolea opened this issue 2 years ago • 3 comments

In #3722 we disabled WriteRead*MissingPerformGets` tests since they were disabled before this big refactoring but after running clang-format they got re-enabled as the gtest TEST_F does not work if its expanded in a multi-line invocation as it was before this PR. This needs to be resolved.

Enabling these tests results errors when BP5 is used.

Originally posted by @vicentebolea in https://github.com/ornladios/ADIOS2/issues/3722#issuecomment-1656318408

vicentebolea avatar Jul 28 '23 20:07 vicentebolea

They were disabled at least since 2018 and edited in this commit: e2f7f7ea6c

vicentebolea avatar Jul 28 '23 20:07 vicentebolea

@eisenhauer

vicentebolea avatar Jul 28 '23 20:07 vicentebolea

Yeah, these tests need to be refactored before they'll work with BP5 as they rely upon BP4 behaviour that we explicitly deprecated. Commenting out for now is fine and I'll clean up after this is merged. (There are probably more tests that got disabled at some point and should be re-enabled, so a broader look might be useful.)

eisenhauer avatar Jul 28 '23 22:07 eisenhauer