ed25519 icon indicating copy to clipboard operation
ed25519 copied to clipboard

Quality of life improvements

Open ghost opened this issue 4 years ago • 1 comments

Hello everyone, I took the freedom of renewing the project folder structure to something more organized. Also added a CMake script for building.

The CMake script can build the static library, shared library and test executable all at once. Targeting both x86 and x86_64 through a cmake flag.

Actually the switches for multilib compiling are only supported by GCC and Clang I guess (-m32 for x86 and -m64 for x86_64). I haven't tested with MSVC.

I removed one unused include at src/test.c:10.

ghost avatar Mar 26 '21 01:03 ghost

Generally speaking, I would recommend asking the maintainer before doing something as invasive like this.

This contains two different changes. One is reorganizing the code: moving the header files to a separate directory and changing the include paths. The other is adding a CMake file. The latter isn't particularly disruptive, the former on the other hand will disrupt other users. I don't really understand why that would be necessary in the first place.

Or why you called this Quality of life improvements instead of Add CMake support. Other people may not share your preferences of build system.

Leont avatar Nov 23 '21 23:11 Leont