atom-react icon indicating copy to clipboard operation
atom-react copied to clipboard

Published 20 hours ago • verified publisher icon orktes

respect react/jsx-closing-bracket-location

Open dmnd opened this issue 9 years ago • 6 comments

Airbnb's react style guide is quite popular. But the indentation rules of this package are incompatible with it. Here's the style guide rule. Below is what this package defaults to.

image

Is there a way to get Atom to respect my eslint settings? Failing that, it would be nice to make the closing > location configurable at the package level.

dmnd avatar Jan 01 '16 01:01 dmnd

:+1:

jeffshaver avatar Jan 04 '16 03:01 jeffshaver

Hi!

@jeffshaver just did a PR concerning this (though it is'nt reading eslint conf). Kudos on that. Reading/respecting eslint rules is a separate feature that is worth pursuing. I'll add a ticker for that.

https://github.com/orktes/atom-react/pull/131

orktes avatar Jan 04 '16 06:01 orktes

Note that the PR (https://github.com/orktes/atom-react/pull/131) was merged and then reverted (https://github.com/orktes/atom-react/commit/22aea6e6d54aa646d321b732ecec8a76014f4233). Looking forward to this feature!

axelson avatar Jan 27 '16 20:01 axelson

I'm looking forward to have this feature too!

hnordt avatar Feb 18 '16 02:02 hnordt

I have had this problem for the last 6 months. A fix would really be appreciated.

Silviu-Marian avatar Nov 18 '16 16:11 Silviu-Marian

Still working this way.

nukeop avatar Feb 19 '18 10:02 nukeop