orklah

Results 221 comments of orklah

Well, the question is, does `Type::intersectUnionTypes` sometimes return a `Never` anyway? If it can happen, it would definitely mean a InvalidIntersectionType should be emitted and your change would not do...

So, when CURLOPT_RETURNTRANSFER is set, curl function return a string but when it's not set it returns `void`? There are no cases where they could return null even with CURLOPT_RETURNTRANSFER...

Let's revert the change that was made, it would be great to have a better behaviour that could detect the flag, but as long as we don't have it, it's...

Would there be any kind of downside if we change the emacs format for everyone? (maybe for people using small screens or multiple windows in a screen?)

Cool, then I guess you can propose a PR to change this! It should be pretty easy, here's the file that control this: https://github.com/vimeo/psalm/blob/4.x/src/Psalm/Report/EmacsReport.php

Yeah, that makes sense, we should try to keep this rule consistent

Code seems good, could you add some tests for RiskyCast please?