orklah

Alright, looks like we didn't get more comments. I'm ready to merge, I just need to make sure you're ready to do the last part (otherwise, it won't make much...

I wonder if this is a change big enough to consider delivering V5 soon and merge for a V6 that we would start immediately after. All things considered, we probably...

Yeah, September is as good a date as any, we just need to lock a date and keep it. I'll leave this unmerged for now, it may be hard to...

Thanks for feedback Matt! Did you had issues with plugin authors on previous majors? This is definitely a change that will affect them directly

Good catch! I have a small guess that there's a mistake here: https://github.com/vimeo/psalm/blob/f9450656e1666fbf6ceb8b419b2d02d065fb76b5/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/VariableFetchAnalyzer.php#L155 This class is in charge of setting the type for a given variable we just read. For...

weird, the second link doesn't show an error anymore

Note that the error is very much raised, as long as you're not in global scope: https://psalm.dev/r/bca86bf891 Basically, if you're in global scope, anything could be defined, we just have...

It must be a pretty niche issue but it's correct given the only non-empty falsy string is '0' and it can't be the result of the concatenation of two other...

It's one of the feature that was implemented after Matt departed from the project, so sadly, it's possible it was added without a "big picture" mindset at the time. I...

> Each such fix for me is a debugging exercise There's a few modules in Psalm I know and I can pinpoint some issues, but aside from that, I'm really...