orklah

Results 221 comments of orklah

I think it could work already if we allowed Psalm 5 but I don't have much time do to tests (and because I'm lazy and I wasn't sure it would...

Please try running with Psalm 5. Also, depending on the codebase it may not be surprising for Psalm to consume that much

Well, more precisely, Iterator has 2 templates. When it is implemented, a `@template-implements` is expected. It should look like `@template-implements \Iterator` where `TKey` and `TValue` are either template themselves or...

it's used here: https://github.com/googleapis/google-cloud-php/blob/main/Storage/src/Bucket.php#L651, not sure if it's used in other places

Sorry, my answer was not clear. What I meant is that there is an annotation that is using ObjectIterator as if it had a template here: https://github.com/googleapis/google-cloud-php/blob/main/Storage/src/Bucket.php#L706 But ObjectIterator doesn't...

Well, basically it should be here: https://psalm.dev/r/9641c94eec But yeah, that's weird

I'm up for improving the workflow here, but enabling all of this for all projects would be a nightmare for new users. We don't want to bother users with immutability...

There are other issues related to callmap consistency it seems

Seems like we have no particular source of types for php_user_filter. it must comes from reflection, so Psalm behaviour will depend on the php version used to run it. This...

Seems like Stubs are scanned but not analyzed. Due to how Psalm runs, I don't think we can just select what we want to check and what we don't want....