orklah

I'm not sure I understand. You're not supposed to run inspections against third-party code. And once you implements or inherit third-party code, you're free to do whatever you want with...

There is one case where the third-party code has a return type and you add another one, then it blows. But it should in that case. I guess a Quick-Fix...

Hi @kalessil , it seems that it's the same as one of the cases here: https://github.com/kalessil/phpinspectionsea/issues/1143#issuecomment-450931889

Hey! Thanks for the feedback. Don't worry, no judgment there, the project for which I made this plugin initially was probably worse! I'll try to take a look at it...

Hey! I'm pretty open to improving the plugin but I didn't quite caught what you want to add exactly. Could you rephrase maybe?

Oh right, go ahead, I should have done that from the start! No need to add an opt-in, I prefer user to suppress the error instead if they don't want...

Yeah, there's currently a few limitations that would need to be improved. Mainly: - I don't risk touching types known through docblock types: https://github.com/orklah/psalm-strict-equality/blob/main/src/Hooks/StrictEqualityHooks.php#L55. I made this plugin to refactor...

> Correct me if I'm wrong, but one extremely common case that is a low hanging fruit to be auto-fixed is if 1 side is union and the other side...

I'd accept any improvement that is proved safe (like mentionned before, the goal was to make a first sweep without worrying, even if the codebase don't have tests, so I...

What could be the next step for anyone wanting to work on Psalm's integration? If there's grunt work to be done, maybe I or anyone else could help?