orklah

@AndrolGenhald I'm surprised this was not fixed though. Is there something special here?

Oh yeah, right, forgot the inferred type has priority

This could be improved by adding a nested conditional here: https://github.com/vimeo/psalm/blob/master/stubs/CoreGenericFunctions.phpstub#L576 if we have an `array`, we could stop assuming the return will be a `non-empty-string`, we would loose the...

PR for reference: https://github.com/vimeo/psalm/pull/7268 I think the @internal was added in bulk based on the directory of the class. It doesn't seem to make sense to have an internal class...

There comes a point where Psalm can't process what you throw at it anymore. It could certainly be improved, possibly by still processing part of the condition when it's possible.

Yeah, this would need to be looked at. I still think it's Psalm dropping a complex expression, but if the false === is working, it may be possible to make...

Yeah, that looks like it would work :) In fact, you can check that it does by just renaming the functions: https://psalm.dev/r/b9f82704bf Note that is theory, a non-empty-list is a...

It's okay :) We're short staffed too! Issues are still useful for other users when searching an issue or to centralize discussions

Well, the constructor may also change when using docblocks that declare templates or things like that. I'll keep this open because it probably could be improved but I'm not sure...

Did you read the doc on that issue? https://psalm.dev/docs/running_psalm/issues/UnsafeInstantiation/ Psalm provides a `@psalm-consistent-constructor` which will ensure that each child of your class is actually compatible with the class that uses...