orklah

Note: I don't know Doctrine enough so I may ask stupid questions :) Is the creation of a new Collection necessarily mutable-free (if so, should Collection::__construct be flagged as mutation-free)?...

Yeah sorry, it's on my list, I'll get to it soon

Oh. I just realized you didn't see my first round of comments because I didn't publish them :( sorry. I thought you responded to it earlier but it was just...

Psalm doesn't have this but it could be interesting (especially because Psalm sometimes struggle to assign values to classes with templates that were never properly created) I doubt I'll be...

When Psalm runs, it treats any notice as an error and crash. While it's okay for Psalm own code, when Psalm has to use a custom autoloader or runs code...

Yeah, that's expected given the explanation above. Feel free to push a fix or to ask for more details as to how it could be fixed!

The issue here is a possibly not precise enough refinement: https://psalm.dev/r/a71c257367 The isset turns the `list` into a `array{10: string}` This is technically correct but it's not the best way...

Yeah, a few things: - substr on literal strings is not computed right now, so it result in a generic string by default. You could totally contribute to that change...

> ctype_* functions return true not only for asserted strings but also for some ASCII codes passed as int. doesn't matter a lot, all of that will be considered numeric....

@SamMousa I think your PR number is wrong in your message