Sam Lee

Results 229 comments of Sam Lee

@astrofrog The problem persisted in the latest astropy v7.1.1 release and the current `main`. The sample codes above still fails, with essentially the same error / stacktrace.

The triple (or multiple, in general) notifications: After I come back to the notebook browser tab, there could be 1 or more (I've seen up to 5 or 6) notifications....

In my setup, `doc.config.reconnect_session = False` does not seem to work. Instead `doc.config.notify_connection_status = False` does appear to suppress the message (regardless of the value of `reconnect_session`). --- A couple...

I attempted the fix in [data_info.py](https://github.com/astropy/astropy/blob/8407999759909e5e24cc45fa69bfc5c936564d75/astropy/utils/data_info.py#L378-L382) , mentioned in #16352 . The result is a mix. ```python def __getstate__(self): return getattr(self, "_attrs", None) def __setstate__(self, state): if state is not...

Not sure if it's intentional: the PR also has (unrelated) change in SearchResult sort order . The change in `remove_outliers()` itself looks good to me.

It'd be better if poetry is installed in its own isolated environment, separate from lightkurve, to avoid dependencies conflicts. https://python-poetry.org/docs/main/#ci-recommendations suggests something like the following: ```sh export POETRY_HOME=/opt/poetry python3 -m...

@afeinstein20 commit e3ac99e116e3c3573adaf5f06d7a4ae0e3edfdb1 does a partial fix on the CBVs. It updates the code path in `targetdata.py`, but not the correspond code path in `update.py` . (The logic is duplicated...

@Nschanche I'm re-opening the issue because: 1. PR #1518 is still open. 2. PR 1518 addresses the CI part. But it does not address the developer documentation. I've just added...