Ori Amizur

Results 37 comments of Ori Amizur

/test edge-e2e-metal-assisted-static-ip-suite /test edge-e2e-metal-assisted-bond

/test edge-e2e-metal-assisted-static-ip-suite

> I'm a bit worried that parsing out the nmconnection file is a bit fragile. We are already doing it here: https://github.com/openshift/assisted-service/blob/904ee715faa05ede09fad39718fc64ece60a18d0/pkg/staticnetworkconfig/generator.go#L139-L165 - so it isn't very different. So if...

> Are you sure that this isn't going to cause issues for bonds/vlans? It should be tested - like any other change. > Do we have a test anywhere for...

/test edge-e2e-metal-assisted-static-ip-suite /test edge-e2e-metal-assisted-bond

/test edge-e2e-metal-assisted-static-ip-suite /test edge-e2e-metal-assisted-bond