Use masked values for secret values

Open orhun opened this issue 11 months ago • 3 comments

We should use e.g. SecretString from secrecy (instead of std::string::String) for handling sensitive values such as:

https://github.com/orhun/rustypaste/blob/8954ce4fb775fec7c7c89bcd1deb7fd90b60b52e/src/config.rs#L54

Feb 03 '25 15:02 orhun

Hmm, this is probably not a good first issue. One problem is that that it is not pssible to have a HasHset<SecretString>. I searched a bit, but couldn't find a solution, but I guess my Rust knowledge is limited...

Mar 19 '25 00:03 tessus

Hmm I guess that's because SecretString does not implement Hash and Eq... It might be worth reporting it to upstream to get it fixed.

Mar 19 '25 21:03 orhun

@orhun I think you are more qualified to continue the discussion at https://github.com/iqlusioninc/crates/issues/1299

Mar 20 '25 17:03 tessus