kermit icon indicating copy to clipboard operation
kermit copied to clipboard
verified publisher icon orhun

Implementing internal keybindings configurable via config file (bindi)

Open jzbor opened this issue 1 year ago • 4 comments

See also #23

jzbor avatar Apr 10 '24 16:04 jzbor

Now based on #24

jzbor avatar Apr 11 '24 22:04 jzbor

Looks really good! I'm thinking if we should make the bindi commands case insensitive for the sake of simplifying the config. What do you think?

orhun avatar Apr 16 '24 21:04 orhun

Oh my bad, I think it is already implemented that way. I fixed it in the config also.

jzbor avatar Apr 17 '24 22:04 jzbor

Can we not base this on #24 just for the sake of moving forward? I'd like to get this feature in 🐻

orhun avatar Apr 26 '24 15:04 orhun

Yes, will do

jzbor avatar Apr 29 '24 18:04 jzbor

Can we not base this on #24 just for the sake of moving forward? I'd like to get this feature in 🐻

Done

jzbor avatar Apr 29 '24 20:04 jzbor

Just tested this and I guess the default key bindings are not available we provide the configuration via -c option, right? Is there a way to embed defaults into the code? What do you think?

orhun avatar Apr 30 '24 11:04 orhun

Just tested this and I guess the default key bindings are not available we provide the configuration via -c option, right? Is there a way to embed defaults into the code? What do you think?

I have now implemented default key bindings

jzbor avatar May 01 '24 10:05 jzbor

LGTM! Just one last comment 🐻

orhun avatar May 03 '24 20:05 orhun

I will check out your comment in #24 soon! I'm planning to get that one in and create a release 🐻

orhun avatar May 08 '24 16:05 orhun