Ingmar Inʒo Splitt
Ingmar Inʒo Splitt
There are even better integration-algorithms available, but they all cost cycles. I like the idea changing to the trapezoid-method. maybe we should make it optional with a compilerswitch?
Your committed implementation could be even simpler because you don't use the new variable more than once and can safe the 4byte ram: ITerm+= (ki \* (error + *mySetpoint -...
You are right when you want to maintain the readability and allocate a local variable: double lastError = *mySetpoint - lastInput; ITerm+= (ki \* (error + lastError) / 2.0); This...
is [this](https://github.com/RobertCNelson/omap-image-builder/blob/master/Ubuntu_22.04-arm64.md) what you are missing? I think this issue can be closed.
Thanks for the feedback! I had a a chance to try this on a bunch of BBone Green - PCB version 1.0. Four of them are 3y old, but untouched...
@ARizzo35 i feel you. i would love to see the previous interface getting still supported. wouldn't it be possible to allow both? Maybe with a different function-name?
Sorry, i got no notification about new messages in this thread :( I added a doc-string and extended the main readme with the example.
Any chance that it gets ever mainlined? It's a small but helpful feature for cleaner and more pythonic code.
Is there a reason to stall this? Your requested changes were implemented almost 2 years ago. i rather prefer that this PR is closed if it is unwanted so I...
@ferdnyc keep in mind that there is a massive overhaul coming (#1361 and #1371). File structure and check-design are changing significantly.