organicmaps
Show more POI types in poi info (PP) subtitle
#8481 has added most common types, but there are more.
power
piste:type
shop (generic) https://www.openstreetmap.org/way/355649602
shop(generic) https://www.openstreetmap.org/way/355649602
I see. This is because we are filtering out level 1 types. @vng Any alternative idea on how to show level=1 shop but ignore level=1 amenity ?
https://github.com/organicmaps/organicmaps/blob/ab5eaced779a44938944f9ce0faa67eb19cbfab0/indexer/map_object.cpp#L109-L113
The original generic amenity was amenity=clock: https://www.openstreetmap.org/node/489786064
I have a better idea than filtering the generic amenity. Let's leave it as is, and collect/fix user reports by adding missing amenities instead into OM. WDYT?
I see. This is because we are filtering out level 1 types. @vng Any alternative idea on how to show level=1
shopbut ignore level=1amenity?
Make one of them an exception.
Or better make shop=yes transform into shop-yes (not generic shop).
I have a better idea than filtering the generic amenity. Let's leave it as is, and collect/fix user reports by adding missing amenities instead into OM.
This is good, but it'll take a lot of time to add all missing tags (some of them might be niche / have very little use).
Probably it makes more sense not to match e.g. amenity=clock into amenity at all (but might break some legit cases, needs research).
This is good, but it'll take a lot of time to add all the missing tags (some of them might be niche / have very little use).
The goal is not to add all tags (we may reach it someday eventually), but to add important/needed/useful tags (to users). Providing more detailed info on the map is one of the strongest features of OM/OSM.
Displaying "Clock" instead of "Amenity" is definitely more useful. And hacks are not needed.
Displaying "Clock" instead of "Amenity" is definitely more useful. And hacks are not needed.
Sure! But do I understand right that the way you suggest to do it
I have a better idea than filtering the generic amenity. Let's leave it as is
is to continue to display generic "Amenity" if a specific full type is not supported yet?
Yes. It will motivate us to add a new type based on discoveries and user reports )
Yes. It will motivate us to add a new type based on discoveries and user reports )
But that also means that for types that we decided not to add (e.g. too little use) or are too slow to add (usual stuff :)) users will see a quite confusing "Amenity". In English it doesn't look too bad compared to translations to some other languages :)
If you guys think we should still remove "Amenity", we could do something like this to detect generic amenity without matching amenity subtypes, which is clearer than previous code. And It will not remove generic shops for example.
auto const & isAmenity = ftypes::IsAmenityChecker::Instance();
if (isAmenity(type) && ftype::GetLevel(type) == 1))
continue;