organicmaps icon indicating copy to clipboard operation
organicmaps copied to clipboard

Published 20 hours ago • verified publisher icon organicmaps

Minor update of liboauthcpp and a few warning fixes

Open biodranik opened this issue 11 months ago • 6 comments

Thanks to @Osyotr for the MSVC build log: https://github.com/organicmaps/organicmaps/files/14728637/organicmaps-win-build-log.txt

biodranik avatar Mar 22 '24 23:03 biodranik

Hmm, looks like liboauthcpp is not needed/used anymore when oauth2 is merged, right @strump ?

biodranik avatar Mar 23 '24 00:03 biodranik

Base64/SHA1 stuff is used in other places.

Osyotr avatar Mar 23 '24 06:03 Osyotr

Base64/SHA1 stuff is used in other places.

I see, in coding. Is it the best possible implementation that we can use? The author didn't update the library for 6 years. Are there other better/faster alternatives? @Osyotr

biodranik avatar Mar 23 '24 06:03 biodranik

@biodranik oauth2 doesn't use liboauthcpp. Maybe we can replace it with SHA1 lib

strump avatar Mar 23 '24 09:03 strump

Are there other better/faster alternatives?

IMHO it's not worth adding an external dependency over these two algorithms. It's possible to rip out code from https://github.com/weidai11/cryptopp (BSL-1.0).

Osyotr avatar Mar 27 '24 11:03 Osyotr

@biodranik oauth2 doesn't use liboauthcpp. Maybe we can replace it with SHA1 lib

Who said SHA1??? Do we still have SHA1 anywhere in the code?

rtsisyk avatar Apr 04 '24 06:04 rtsisyk