organicmaps icon indicating copy to clipboard operation
organicmaps copied to clipboard

Improve dark style visibility

Open dvdmrtnz opened this issue 1 year ago • 1 comments

In this PR:

  • Simplify color names and remove unused colors
  • Make buildings a bit lighter in dark style
  • Make some labels lighter for improved visibility in dark style

Before/after:

dvdmrtnz avatar Feb 17 '24 21:02 dvdmrtnz

@pastk Do you like trunk0, trunk1, ... building0, building1, ... notation?

On one hand its in line with the

@green0: #CFD5A8;
@green1: #C6CF93;
@green2: #BCC87E;
@green3: #B3C471;
@green4: #AEC26B;
@green5: #B0C270;
@forest: #AABF65;
@green6: #888C38;

(where its apparently not easy to put that many grades in words) but for the roads its maximum 3 grades (light / med / dark) and it improves at-a-glance understanding of the color role a lot.

So my preference is to continue use a more descriptive wording approach for roads and buildings colors. But maybe we need better wording, because the meaning of light/dark is reversed in the dark/night mode. Maybe "strong/med/mild"? Please help with better synonyms 🙏

pastk avatar Feb 18 '24 07:02 pastk

From the screenshots I can say it looks much better IMO. I almost don't use dark mode because of the lack of readability. This is the way to go!

patepelo avatar Feb 18 '24 16:02 patepelo

It would be great to check it in the car at night first before the merge. The master now doesn't highlight houses in the vehicle nav mode, and that looks convenient, less distracting. Only numbers are visible.

biodranik avatar Feb 18 '24 18:02 biodranik

Screenshots looks really nice! Waiting for update

kirylkaveryn avatar Feb 29 '24 07:02 kirylkaveryn

I've tested it in the car. IMO it looks too bright and distracts the driver. In the master branch houses are almost invisible, only their numbers are conveniently seen if necessary.

But this patch does not change the vehicle style, right?

biodranik avatar Feb 29 '24 07:02 biodranik

@dvdmrtnz Great job, contrast improvements are always welcome, especially for the text labels!

@biodranik Speaking of design direction, what do you think of Waze night scheme for driving? They use brighter colors than we do, but personally I find it easier on the eyes. Maybe due to the contrast Waze stays very legible even with lower screen brightness.

euf avatar Feb 29 '24 08:02 euf

I've tested it in the car. IMO it looks too bright and distracts the driver. In the master branch houses are almost invisible, only their numbers are conveniently seen if necessary.

But this patch does not change the vehicle style, right?

vehicle style does not change

dvdmrtnz avatar Mar 03 '24 19:03 dvdmrtnz

Rebased

dvdmrtnz avatar Mar 03 '24 19:03 dvdmrtnz