organicmaps
[ios] Consistently remove grey bar below header in place pages
This is even more a hack than the previous code, which was marked as a workaround. However, it works - I have not seen the problem described in #3082 with this fix and the lag is not noticeable.
There is probably a better way to do this, but since my bug report issue was not fixed, I decided to give it a try (although I have no experience developing iOS apps).
Although I would argue that this doesn't introduce anything new (the async queue also has a delay, albeit lower one), I can understand your position as maintainer :)
Anyway, it would be helpful to get a hint from someone familiar with the ios codebase, where/when the visibility of place page subviews might change.
@nojus297 When I debugged it, I used breakpoints in different places. The current implementation is complex, so you'll need some time to understand it. The good news is that we want/plan to refactor the place page anyway and improve it. So if you invest your time into this issue, it may be useful for future ;-)
I did spend quite some time trying to figure this out, but have not managed to fix it. All I figured out was that the header view of place page has some trailing spacing, but I could not find where it comes from (storyboard or any of the controllers), but the other views resizing in the stack are not the only problem.
Not sure how helpful breakpoints are there, as all the arrangements are made before it is even rendered (I think, haven't debugged properly as it's not very pleasant on a VM and a small resolution window).
VM is the only way I can run the Xcode, required to build Organic maps for ios.