organicmaps icon indicating copy to clipboard operation
organicmaps copied to clipboard

Searching specific POI category

Open devdan opened this issue 2 years ago • 7 comments

Any OSM POI category should be searchable. There are some broader categories that can be searched (e.g. touristic places, but I cannot search for any category, e.g all castles in the surroundings).

devdan avatar Aug 06 '22 12:08 devdan

To be searchable, it should be included here: https://github.com/organicmaps/organicmaps/blob/master/data/categories.txt

Please list types present in OM (https://github.com/organicmaps/organicmaps/blob/master/data/categories.txt), but not searchable.

biodranik avatar Aug 06 '22 12:08 biodranik

"post office" is in this list but when searching for it I only receive post offices with the exact phrase "post office" in the title (The UPS Store and FedEx locations for example are tagged as post_office but not in the results, not to mention government post offices with different name tags)

zyphlar avatar Aug 08 '22 23:08 zyphlar

Would you accept a PR that includes all categories of OSM?

devdan avatar Aug 09 '22 14:08 devdan

with the exact phrase "post office" in the title

@zyphlar what is your language? Did you check if there are proper translations in data/categories.txt? We match categories by the exact text in that file.

biodranik avatar Aug 09 '22 14:08 biodranik

English, so the exact string "post office".

The file says this, I'm not sure what it means:

amenity-post_office|@post
en:3Post Office|U+2709|U+1F3E3|U+1F4E8|U+1F4E9|U+1F3E4|U+1F4EF

Interestingly the category "Post" searches everything as expected, but typing the exact string "Post" into the search box reverts to only things with that in the name. Adding the word "office" to the end of the "Post" category also works properly, but copy-pasting the resulting string "Post office" into the search bar goes back to failure. Very very strange, as if there is something magical about clicking on a category.

zyphlar avatar Aug 10 '22 06:08 zyphlar

I don't mean the whole list of all possible categories that you can search for but the small list if you go to Search/Categories. There are only a few items in this list. So, unless you know what to search for, you cannot find anything. With the help of this list you could explore new categories.

What do you think about the suggestions of having an entry called "more ..." at the end of this short list. When clicked you are presented with a huge list of all OSM categories?

devdan avatar Sep 13 '22 11:09 devdan

What about actually putting in that existing list all OSM categories and reusing their icons from the map? And properly suggesting them when a user types characters? And then putting more frequently used categories at the top of the list? That would be an ideal solution, right? :)

biodranik avatar Sep 13 '22 22:09 biodranik