gping icon indicating copy to clipboard operation
gping copied to clipboard

Consider adding separation when stats are maximally compressed

Open dev-msp opened this issue 2 years ago • 2 comments

image

There's a rather unfortunate coincidence where "min" is both the name of a stat and a stat unit, so that when the frame is resized small enough, it looks very much like the last value was N minutes vs ms. Seems the best fix would involve some 1-char separator between stats (|, maybe?), but no strong opinion.

dev-msp avatar Jul 01 '23 18:07 dev-msp

I want to add to this -- there are other issues with the numbers on small screens.

Screenshot 2024-11-29 at 11 36 06
  • There's a space between the keyword and its value, but no space between the value and the next keyword.
    • This violates the visual principle that things that belong together should also be grouped together in terms of spacing.
    • You might wonder, Is the avg now 11.333 or 3.579?
  • As OP already pointed out, the previous problem also leads to units and the following key collapsing.
    • Did the last sample take 1.882min (i.e. minutes)?
    • What does mmax mean?
    • And what is mjtr?
  • Often, the units are missing entirely, and it's hard to tell whether we're talking microseconds, milliseconds, seconds or even minutes.

In my mind:

  • there should always be a space between a value and the follow-up key,
  • there should always be a unit behind the number,
  • there should always be at least, say, 3 digits + decimal place per value; however,
  • the space between keyword and the following value is optional, and
  • if the screen gets too small to follow these rules, then the end of the line should simply be cut-off.

fxnn avatar Nov 29 '24 10:11 fxnn

+1 for both comments here above! I love the level of detail provided by @fxnn , it's like you read my mind 😂

RaffaeleBianc0 avatar Jul 16 '25 07:07 RaffaeleBianc0