gping icon indicating copy to clipboard operation
gping copied to clipboard

Published 20 hours ago • verified publisher icon orf

"Max" appears to be unrelated to the actual graph

Open jwalton opened this issue 3 years ago • 2 comments

image

According to this the "max" is 37ms, but looking at the graph we can clearly see several spikes up into 50ms range. The demo gif in the README.md has this same problem.

jwalton avatar Dec 02 '20 16:12 jwalton

I was just digging into this, nice eyes! I suspect it's a matter of aliasing or rounding on the part of the tui::Chart widget. I'm not seeing the values in the histogram matching what's being displayed, so it doesn't seem like an issue with the data calculation:

Screen Shot 2020-12-02 at 9 27 36 AM

thepacketgeek avatar Dec 02 '20 17:12 thepacketgeek

ah yup, it's weirdness with the label rendering and not the data itself. I have an approximate fix in #116 , the math here is interesting with the Chart padding.

thepacketgeek avatar Dec 02 '20 18:12 thepacketgeek