cookieconsent icon indicating copy to clipboard operation
cookieconsent copied to clipboard

Make the category checked only if all the services are checked

Open anthony0030 opened this issue 1 year ago • 3 comments

I have noticed that the category gets checked even if one of the services is checked, this seems strange to me as when you toggle the category all the services get toggled.

All the tests still pass.

A different approach that I would need some help implementing: Add an option for the category logic with two options "AND" and "OR". The "AND" option would mean that all services would need to be enabled for the category to be enabled. The "OR" option would be if any service is enabled (how it currently works).

anthony0030 avatar Sep 12 '24 09:09 anthony0030

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
cookieconsent-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:38am

vercel[bot] avatar Sep 12 '24 09:09 vercel[bot]

Deploy Preview for cookieconsentv3-playground canceled.

Name Link
Latest commit 8e613c4ae64f86bf84449b0e9db41fd9018a3acd
Latest deploy log https://app.netlify.com/sites/cookieconsentv3-playground/deploys/66e2b68a5768ad0008b1fa0c

netlify[bot] avatar Sep 12 '24 09:09 netlify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 19 '24 09:10 stale[bot]

Seems like something useful. The behavior of the toggle button can be misleading.

theonlyriddle avatar Oct 22 '24 08:10 theonlyriddle

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 23 '24 18:11 stale[bot]

@orestbida could you please take a look at this PR?

anthony0030 avatar Nov 25 '24 08:11 anthony0030

The current toggle behaviour is the only one valid for me: whether you have accepted one or all tracking services, tracking is enabled nonetheless, so treat the category as enabled.

Having an option to make it so that the category is on only when all its services are enabled would be way more misleading for the end user.

orestbida avatar Dec 03 '24 21:12 orestbida

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 03 '25 00:01 stale[bot]