cookieconsent icon indicating copy to clipboard operation
cookieconsent copied to clipboard
verified publisher icon orestbida

Fix eraseCookies domain bug and expand tests

Open imnasnainaec opened this issue 1 year ago • 4 comments

imnasnainaec avatar Aug 13 '24 15:08 imnasnainaec

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
cookieconsent-docs ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:07pm

vercel[bot] avatar Aug 13 '24 15:08 vercel[bot]

Deploy Preview for cookieconsentv3-playground canceled.

Name Link
Latest commit bebdd6fdfca3513827deef38f0d21a0ba1dbc991
Latest deploy log https://app.netlify.com/sites/cookieconsentv3-playground/deploys/66bcb9fec55c270008dafa7d

netlify[bot] avatar Aug 13 '24 15:08 netlify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 21 '24 22:09 stale[bot]

@orestbida You had a comment about this pr here, which I responded to. I'm not sure if there were other things you wish to review or test.

imnasnainaec avatar Sep 23 '24 12:09 imnasnainaec

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 28 '24 21:10 stale[bot]

Improvements in this pr:

  • Expand docs for eraseCookies
  • In eraseCookiesHelper, don't use erase(cookieName); because that causes a bug, deleting unintended cookies when a domain was specified; rather, allow erase(cookieName, customDomain); to cover the case when customDomain is empty
  • In the erase function, only add a . to the start of the domain if it's nonempty and doesn't already start with a .
  • Update cookie erasure tests to verify the cookie is there before it's erased
  • Add more tests to ensure that a wrong path or wrong domain will not delete a cookie

imnasnainaec avatar Oct 29 '24 12:10 imnasnainaec

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 03 '24 05:12 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 03 '25 00:01 stale[bot]

Happy new year!

imnasnainaec avatar Jan 06 '25 12:01 imnasnainaec

@imnasnainaec Sorry for the late feedback, happy new year too!

LGTM, thanks for the contribution!

orestbida avatar Jan 16 '25 00:01 orestbida