oreparaz
make dudect more portable?
We could make dudect more portable and support other architectures, like ARM. @dfaranha wrote a port to ARM here https://github.com/dfaranha/dudect-arm that we could integrate. I think ARM would be the first target.
It's fairly easy to add this support, we follow the recipe from https://github.com/itzmeanjan/criterion-cycles-per-byte/blob/a270a49652eabf5be9366866613f905f604a18ba/src/lib.rs#L61-L74. It's on my todo list.
Let me know if I should try rebasing and sending a PR with the diffs from my fork. :)
Ah that would be wonderful! Thank you! I believe it'd be mainly a matter of integrating https://github.com/oreparaz/dudect/commit/d708aca8542ac608ea2a2b178468288fbdeac300#diff-22b09f555b924f80b50f3449369c7edb176b83494871b9cc133164c080e91c18 .
@itzmeanjan previously expressed interest in this. @itzmeanjan : are you still interested in this? We can take @dfaranha 's code as starting point.
BTW happy to see you here Diego :)
I'll send a PR tomorrow @oreparaz.
I'm sorry that I've not yet sent a PR :(. It might take some time.
In the mean time, @dfaranha feel free to send PR. I'll be more than happy to review.
I tried rebasing with latest HEAD, but my fork is too old and there are lots of conflicts.
I also do not have an ARM device ready to test right now, but will have one in a couple of weeks!
I also do not have an ARM device ready to test right now, but will have one in a couple of weeks!
No worries @dfaranha.
I just sent a PR https://github.com/oreparaz/dudect/pull/36. I've tested it on multiple targets, it seems to behave ok. I'll continue testing more. cc @oreparaz
No worries @dfaranha ! Thanks for that.
@itzmeanjan : your PR looks great! I have a bunch of testing to do with that PR but from a code review it looks awesome! let's talk in the PR