orenyodfat issues

Results 50 issues of


                                            orenyodfat

test hardfork istanbul

address #671

use ganache 6.8.0 and test for Istanbul hard fork.

https://github.com/trufflesuite/ganache-cli/releases/tag/v6.8.0-istanbul.0

Avatar: genericCall require call to contract

SchemeRegistrar : separate voting machine execution from scheme execution (register/unregister).

to enable voting machine execution even the scheme execution itself will revert. see https://github.com/daostack/alchemy/issues/918 for example. might also consider to add permission check (>=2) on the proposal function .

CR: require externalToken reward is not 0

to prevent ui mistakes

Add (U)controller metaData tests

Add error reason to all 'require'

Enable solium error-reason rule .It is currently 'off' by #492

Add spelling linter check to travis.

If there is such a linter which can catch comments spelling mistake..it will be great.

migrate https://github.com/daostack/arc/releases/tag/0.0.1-rc.56

prepare for daocreator library without build problems.

https://github.com/dOrgTech/DAOcreator/issues/525