contrib-hub icon indicating copy to clipboard operation
contrib-hub copied to clipboard

Some project links in /wannahelp point to https://api.github.com/*

Open jaunesarmiento opened this issue 11 years ago • 6 comments

Hi,

I'm not sure if this is valid but some of the links in /users/username/wannahelp point to the JSON resource of the project. (e.g. https://api.github.com/repos/gittex/App-Standby)

jaunesarmiento avatar Dec 01 '13 19:12 jaunesarmiento

It looks like it points to https://api.github.com/repos/gittex/App-Standby instead of https://github.com/gittex/App-Standby.

sunnyrjuneja avatar Dec 02 '13 22:12 sunnyrjuneja

Confirmed bug :bug: Some repos have the wrong url

orendon avatar Dec 02 '13 22:12 orendon

here we're taking the html_url attribute from the github response, we need to check if we're storing the rigth one and validate if we're getting the right value from github for some of this repos.

We love contributions @jaunesarmiento, are you willing to work on a patch for this? We can provide any further assistance if needed

orendon avatar Dec 02 '13 23:12 orendon

if @jaunesarmiento isn't interested, i would be happy to take it on.

sunnyrjuneja avatar Dec 02 '13 23:12 sunnyrjuneja

I can work on this bug. :) On Dec 3, 2013 7:02 AM, "Oscar Rendón" [email protected] wrote:

herehttps://github.com/orendon/contrib-hub/blob/master/app/models/github_utils.rb#L34we're taking the html_url attribute from the github responsehttp://developer.github.com/v3/repos/#list-user-repositories, we need to check if we're storing the rigth one and validate if we're getting the right value from github for some of this repos.

We love contributions @jaunesarmiento https://github.com/jaunesarmiento, are you willing to work on a patch for this? We can provide any further assistance if needed

— Reply to this email directly or view it on GitHubhttps://github.com/orendon/contrib-hub/issues/139#issuecomment-29667506 .

jaunesarmiento avatar Dec 03 '13 03:12 jaunesarmiento

The fix was done on 1d4226cb32a44a545ae73caf290d101d312d8d05

Before closing this issue I'll perform an update over all repos url's we have on production db

orendon avatar Dec 03 '13 16:12 orendon