Aurele Ferotin

Facing this as well, lines 107:114 should be moved above line 87

If you set `LABEL_STUDIO_HOST=http://domain/subpath` and `DOMAIN_FROM_REQUEST=True`, the result will be an exception because: https://github.com/HumanSignal/label-studio/blob/39a92aef950cd2c6a8ac92a39b17b7e1716b52f9/label_studio/core/settings/base.py#L109-L112 If you set `LABEL_STUDIO_HOST=/subpath` and `DOMAIN_FROM_REQUEST=True`, it won't work either cause the variable `LABEL_STUDIO_HOST` will be...

https://github.com/knex/knex-schema-inspector/blob/0f5f9835ef93a076b6f1ee582f300a332d723727/lib/dialects/postgres.ts#L69 This is still fundamentally wrong anyway, because it cannot handle expression, eg. `NOW() + '2 hours'::interval` or anything involving function or operators. Since there is no error handling, I...

> I didn't test it, but it will probably not crash because interval belongs to the set of built-ins in pg-types: It would not crash because the value is an...

> Wondering if we should return a "defaultValueRaw" that doesn't do any parsing magic next to the "defaultValue" that does a best effort to parse it into a workable JS...

Looks good! Would be nice to have a test for https://github.com/knex/knex-schema-inspector/issues/72 too since this was the original reason for this PR.

> IIRC MySQL doesn't differentiate between schema/database It's just that the default schema in MySQL is named after its database, instead of being named `public` like others vendors - but...

OK, that's weird... It means that their concept of a database is different than others. (You can't query table from a database while being in another one in other vendors,...

> Should we include views under regular columns, or have a dedicated `.views()` method? 🤔 Then you'd have to set a filter for columns in order not to encounter the...

I would do a left join lateral with limit 1 instead, that would avoid calculating the row number and adding the last where close. EDIT: apparently not possible, I thought...