ord icon indicating copy to clipboard operation
ord copied to clipboard

Add --rune flag to resume command to enable resuming a specific etching

Open ldiego08 opened this issue 10 months ago • 2 comments

Adds a new --rune <RUNE> flag to allow resuming a specific pending etching. This is useful in automated scenarios (if anyone else is into that kind of stuff) where you'd like to etch something, suspend (perhaps via --no-wait from #3526), do something else, and then resume after the 6 confirmations.

ldiego08 avatar Apr 24 '24 18:04 ldiego08

Thanks for the feedback, @raphjaph! Requested changes have been applied. I've also fixed linting issues. Will add the command to show pending etchings on a separate PR.

ldiego08 avatar May 06 '24 22:05 ldiego08

Almost there! Still needs an integration test. Have a look at tests/wallet/resume.rs. For reasons this can only be tested on Mac and Linux. What system are you on?

@raphjaph took me a while to get around to adding these tests, but here they are! Hope it's looking good. I'm on a Mac, btw.

ldiego08 avatar May 12 '24 20:05 ldiego08