ord icon indicating copy to clipboard operation
ord copied to clipboard

Allow mint submissions as start block is pending

Open coinspiracynut opened this issue 10 months ago • 2 comments

Current implementation only allows mint submissions after the start block is confirmed meaning ord users can not attempt to compete in that block. This implementation allows for submissions at start - 1, which is a good solution for most users. However, a flag to ignore these checks for power users might be a more composable solution.

coinspiracynut avatar Apr 21 '24 19:04 coinspiracynut

Referencing this issue for more context https://github.com/ordinals/ord/issues/3643

0xcruci avatar Apr 21 '24 19:04 0xcruci

Isn't the end check similarly off by one?

If the minting ends at block 80 and block 79 is the current block, new mints won't be accepted in block 80 so don't let people mint after block 79 has been mined

gmart7t2 avatar Apr 22 '24 03:04 gmart7t2

Isn't the end check similarly off by one?

If the minting ends at block 80 and block 79 is the current block, new mints won't be accepted in block 80 so don't let people mint after block 79 has been mined

yes

benbuschmann avatar Apr 22 '24 17:04 benbuschmann

Fixed in #3659.

casey avatar Apr 22 '24 23:04 casey

Thanks @casey!

0xcruci avatar Apr 23 '24 00:04 0xcruci