ord icon indicating copy to clipboard operation
ord copied to clipboard

Minting Off By 1 Error

Open owenstrevor opened this issue 10 months ago • 3 comments

If a mint starts on block 40, ord will not let you mint until that block has already passed. Meaning the first block ord allows you to mint in is actually block 41.

owenstrevor avatar Apr 21 '24 18:04 owenstrevor

I think there must something to ignore errors, I tried to find it last days, I think it's in core of ord wallet

elder-rus avatar Apr 21 '24 19:04 elder-rus

We identified the issue here: https://github.com/ordinals/ord/blob/08bbf566502533217d7c5d24287e9f93b3bfc8a8/src/index/entry.rs#L66

It looks like the height might be the last confirmed block and is 1 behind. If that's the intent, then one fix would be to have the statement be: if height < (start - 1) or if (height + 1) < start

But perhaps there's a bug in height causing the off-by-one. Thanks!

Love, Pizza Ninjas

0xcruci avatar Apr 21 '24 19:04 0xcruci

this is fixed in this PR: https://github.com/ordinals/ord/pull/3645

bFanek avatar Apr 21 '24 19:04 bFanek

Fixed in #3659. Thank you for reporting!

casey avatar Apr 22 '24 23:04 casey