ord icon indicating copy to clipboard operation
ord copied to clipboard

Remove default for parameter `--fee-rate` for `wallet send`

Open veryordinally opened this issue 2 years ago • 2 comments

Implement issue #1747 Given high fee environment many users run into issue with default fee rate of 1.

veryordinally avatar Feb 15 '23 14:02 veryordinally

This looks good to me -- I think we should also make --fee-rate a required parameter on ord inscribe ?

Also we should update the guide to use --fee-rate in the example https://github.com/casey/ord/blob/master/docs/src/guides/inscriptions.md

RarePepeMaximalist avatar Feb 15 '23 16:02 RarePepeMaximalist

Updated the guide, thanks @RarePepeMaximalist for the pointer.

Update for ord inscribe makes sense to me for consistency.

veryordinally avatar Feb 15 '23 17:02 veryordinally

Please include in your review this piece of code. If you are sending an amount of sats rather than an inscription, it will use an RPC command that does not take a fee_rate at all, but relies on the default behavior of send_to_address.

I think this means that even if you require a --fee-rate parameter, it will not be utilized in this instance. So, the program will complain about a fee rate not being set and when you set one it won't use that fee rate provided which is worth fixing later.

https://github.com/casey/ord/blob/b0ca48658d1b5eb911e1a2e3afea675134f9ba4d/src/subcommand/wallet/send.rs#L51-L74

droplister avatar Feb 15 '23 23:02 droplister

Great point @droplister! This is actually the root problem behind #1432. So extremely nice find!

casey avatar Feb 15 '23 23:02 casey