platform icon indicating copy to clipboard operation
platform copied to clipboard

Routing is broken after regular composer updates

Open pixelpeter opened this issue 2 years ago • 6 comments

Describe the bug I'm maintaining an application that is (unfortunately) not used regularly or on a daily basis. That's why I can not say at wich point in time exactly this application started to break. There are no code changes, just regular composer updates to keep the dependencies current.

The URL/form action for the Save command is incorrectly generated as /entities/workspace/1023/addChild/addChild and should be/was before /entities/workspace/1023/addChild

To Reproduce Having this routes defined: image

Which result in these routes: image

That get called by this command: image

Will generate this button action: image

Expected behavior The URL/form action for the Save command is incorrectly generated as /entities/workspace/1023/addChild/addChild and should be /entities/workspace/1023/addChild

Server (please complete the following information):

  • Platfrom Version: 13.9.4
  • Laravel Version: 9.51.0
  • PHP Version: 8.2.1
  • Database: MySql
  • Database Version: 5.7.12 (aurora 2.10.3)

Please help me to solve this issue as I'm currently stuck and running out of ideas. Thanks in advance

pixelpeter avatar Feb 10 '23 12:02 pixelpeter

@SadElephant Can you write a test to reproduce this?

tabuna avatar Feb 14 '23 21:02 tabuna

@pixelpeter Good afternoon, do you have the same bug as in the video? https://youtu.be/5TEyiog0X1k https://youtu.be/FlM-XbVXrjw

SadElephant avatar Feb 16 '23 13:02 SadElephant

@SadElephant as far as I can tell from the vids it looks like the same issue to me

pixelpeter avatar Feb 20 '23 10:02 pixelpeter

Any news on this?

pixelpeter avatar Apr 17 '23 07:04 pixelpeter

Any update on this issue? @SadElephant @tabuna

ravi-n4s avatar Sep 15 '23 09:09 ravi-n4s

Hello, we have fixed a routing issue. Specifically for this issue, a test has been written that reproduces the described behavior. You can find it at the following link:

https://github.com/orchidsoftware/platform/blob/9320978382a6038678ca55f8c57cd8098d017488/tests/Browser/Issue2517Test.php#L12-L53

Also:

https://github.com/orchidsoftware/platform/blob/9320978382a6038678ca55f8c57cd8098d017488/tests/Feature/Issue2517Test.php#L9-L29

Currently, all tests have passed successfully. If the problem persists, please provide us with any additional information or steps to reproduce it.

tabuna avatar Sep 15 '23 19:09 tabuna