ngsi-timeseries-api icon indicating copy to clipboard operation
ngsi-timeseries-api copied to clipboard

factor out in src/reporter/tests/test_timescale_types.py #710

Open NEC-Vishal opened this issue 2 years ago • 3 comments

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
  • [x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
  • [x] I have updated the RELEASE NOTES
  • [x] I have added necessary documentation (if appropriate)
  • [x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

NEC-Vishal avatar Dec 19 '22 05:12 NEC-Vishal

CLA Assistant Lite bot All contributors have signed the CLA ✍️

github-actions[bot] avatar Dec 19 '22 05:12 github-actions[bot]

#710

NEC-Vishal avatar Dec 19 '22 05:12 NEC-Vishal

#710

NEC-Vishal avatar Jan 05 '23 07:01 NEC-Vishal