ngsi-timeseries-api icon indicating copy to clipboard operation
ngsi-timeseries-api copied to clipboard

Replace borg connection manager with thread safe db pool

Open daminichopra opened this issue 3 years ago • 1 comments

Proposed changes

Does changes as per references Fix for Issue

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x ] I have read the CONTRIBUTING doc
  • [ x ] I have signed the CLA
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

  • Replaced "borg" connection used in file connection_manager.py with CrateDB's SQLAlchemy dialect

  • Also, took references from discussion

  • used create_engine connection.

daminichopra avatar Dec 14 '21 10:12 daminichopra

CLA Assistant Lite bot All contributors have signed the CLA ✍️

github-actions[bot] avatar Dec 14 '21 10:12 github-actions[bot]