White Rabbit

Results 188 comments of White Rabbit
trafficstars

Speaking about ENUMS - we describe the logic and motivation here: https://github.com/saveourtool/diktat/blob/master/info/guide/diktat-coding-convention.md#-39-enumerations Our huge experience in big enterprise teams shows that it is very important to use **trailing comma** and...

Speaking about the documentation - it looks like it is really confusing. This inspection expects you to write enum values in UPPER_SNAKE_CASE. Yes, we definitely must update documentation.

> snakeCase = MY_ENUM_ENTRY > PascalCase = MyEnumEntry These are notations: ``` camelCase PascalCase lower_snake_case UPPER_SNAKE_CASE ``` By the default we expect enums in UPPER_SNAKE_CASE (MY_ENUM_ENTRY). But you can set...

I will update documentation in the rule. > Two options: snakeCase(default), PascalCase That is a bug in documentation - author wanted to say `UPPER_SNAKE_CASE` instead of `snakeCase`

> We have the same thoughts :D Welcome to contribute to our project with a such mindset :D

Already done: https://github.com/analysis-dev/diktat/blob/cbeaa96975dd3d9d7971fe81678ed4c060038708/diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/TrailingCommaRule.kt

fuck, isn't this a ktlint problem?