backends icon indicating copy to clipboard operation
backends copied to clipboard

Include video durations in estimatedConsumptionMinutes

Open tpreusse opened this issue 5 years ago • 0 comments

Bug Report

Steps to Reproduce

{
  document(path: "/2019/06/08/das-verlorene-paradies") {
    meta {
      totalMediaMinutes
      estimatedReadingMinutes
      estimatedConsumptionMinutes
    }
    content
  }
}

Live Query

Additional issue: if content is not requested totalMediaMinutes is 0 because it's resolved at request time.

Actual Results

{
  "data": {
    "document": {
      "meta": {
        "totalMediaMinutes": 19,
        "estimatedReadingMinutes": 4,
        "estimatedConsumptionMinutes": 4
      },
      "content": {} // clipped
  }
}

Expected Results

{
  "data": {
    "document": {
      "meta": {
        "totalMediaMinutes": 19,
        "estimatedReadingMinutes": 4,
        "estimatedConsumptionMinutes": 23
      },
      "content": {} // clipped
  }
}

Possible Solutions

  • preprocess totalMediaMinutes at index time
  • add totalMediaMinutes to estimatedConsumptionMinutes unless meta.audioSource.durationMs is present
    • this should still win for e.g. «An der Bar» cases where there is a video and audio file of the same thing and same duration

tpreusse avatar Jun 08 '19 11:06 tpreusse