orbit-db-cli icon indicating copy to clipboard operation
orbit-db-cli copied to clipboard

Add http daemon

Open drbh opened this issue 7 years ago • 5 comments

Copied files server.js add.js create.js get.js from 3c691c032a047e99237af24af6956b9068c314e6 branch of orbit-db-http-server at https://github.com/haadcode/orbit-db-http-server.git

Added a new file in commands that run the daemon. This currently runs in the foreground and can be canceled with CTL + C, also hard coded the port and host to remove unneeded files.

-added the files that the original PR was missing.

drbh avatar Aug 28 '18 15:08 drbh

Continuation of #21. :)

RichardLitt avatar Aug 28 '18 16:08 RichardLitt

bump

drbh avatar Dec 05 '18 20:12 drbh

Thanks for the bump @drbh. I'll be taking a closer look at this tomorrow.

aphelionz avatar Dec 05 '18 22:12 aphelionz

@drbh Would you mind either writing a positive test case or some unit test (which we'll need to merge anyway)?

Another question I have is if we could include the orbit-db-http-server package here instead of copying the files over. Maybe there is something we can do on our end to get that merged and usable for you.

I think adding an HTTP server is an extremely useful addition and besides just wanting to do it right I think we want to generalize this to be useful across all the orbit packages

aphelionz avatar Dec 06 '18 22:12 aphelionz

Happy to move the orbit-db-http-server repo if you want to continue it. Agreed with @aphelionz that making it generic and usable in other projects too would be the best way forward.

haadcode avatar Dec 18 '18 17:12 haadcode