orbit icon indicating copy to clipboard operation
orbit copied to clipboard

Cache emoji icons

Open haadcode opened this issue 8 years ago • 5 comments

The emoji pictures are currently downloaded on request and it makes them to "pop in" when they first appear (either in the channel messages or emoji preview).

The emojis should be cached locally in the repository in client/src/icons/emojis.

Before doing this, we need to check the license for the emojis we currently use (https://github.com/banyan/react-emoji), ie. can we package them with the app?

haadcode avatar May 19 '16 10:05 haadcode

react-emoji is MIT. The emojione assets it uses are under creative commons. I think we can package them with attribution

shamb0t avatar May 19 '16 10:05 shamb0t

Excellent. There's no rush to this. It's more of an enhancement/performance optimization.

haadcode avatar May 19 '16 11:05 haadcode

these should be packaged directly into orbit through ipfs-- there should be a bundle of assets that ships with orbit-- similar to the readme files that ship with go-ipfs

jbenet avatar Oct 10 '16 17:10 jbenet

@haadcode you are currently using the http version for jsdelivr, but it is also available on https:

  • http://cdn.jsdelivr.net/emojione/assets/svg/1F642.svg
  • https://cdn.jsdelivr.net/emojione/assets/svg/1F642.svg

that would at least make chrome less sad about insecure content

dignifiedquire avatar Dec 13 '16 13:12 dignifiedquire

Thank @dignifiedquire! This was done here: https://github.com/haadcode/orbit/commit/3a4fc96ce17b28824ce7a959424af50d6933c3fc. It fixes emojis in orbit-inside-orbit case where they didn't load previously.

👍

Next: cache them locally or load from IPFS.

haadcode avatar Dec 13 '16 14:12 haadcode