orbit
orbit copied to clipboard
Cache emoji icons
The emoji pictures are currently downloaded on request and it makes them to "pop in" when they first appear (either in the channel messages or emoji preview).
The emojis should be cached locally in the repository in client/src/icons/emojis.
Before doing this, we need to check the license for the emojis we currently use (https://github.com/banyan/react-emoji), ie. can we package them with the app?
react-emoji is MIT. The emojione assets it uses are under creative commons. I think we can package them with attribution
Excellent. There's no rush to this. It's more of an enhancement/performance optimization.
these should be packaged directly into orbit through ipfs-- there should be a bundle of assets that ships with orbit-- similar to the readme files that ship with go-ipfs
@haadcode you are currently using the http
version for jsdelivr, but it is also available on https:
- http://cdn.jsdelivr.net/emojione/assets/svg/1F642.svg
- https://cdn.jsdelivr.net/emojione/assets/svg/1F642.svg
that would at least make chrome less sad about insecure content
Thank @dignifiedquire! This was done here: https://github.com/haadcode/orbit/commit/3a4fc96ce17b28824ce7a959424af50d6933c3fc. It fixes emojis in orbit-inside-orbit case where they didn't load previously.
👍
Next: cache them locally or load from IPFS.