geoclimate icon indicating copy to clipboard operation
geoclimate copied to clipboard

Indicator calculation in Workflow

Open j3r3m1 opened this issue 3 years ago • 2 comments

Currently, the indicators that are calculated in workflows are not the same depending on the "indicatorUse". The way they are calculated in workflow is quite complicated and should be modified since new "indicatorUse" will soon be implemented.

Current version (see https://github.com/orbisgis/geoclimate/blob/978ef9bd5879bb4f566f7b19839b1880cc68cce5/geoindicators/src/main/groovy/org/orbisgis/geoclimate/geoindicators/WorkflowGeoIndicators.groovy#L60): if indicatorUse is LCZ: calculation_indic0 if indicatorUse is TEB or indicatorUse is LCZ: calculation_indic1

New version: if indicatorUse is LCZ: calculation_indic0 calculation_indic1 if indicatorUse is TEB: calculation_indic1

The problem is that the calculations might be done for several uses, thus you do not want to recalculate something already calculated (for example indic_1 in the example)... We should find a way of getting the information that this indicator has been calculated and thus is not needed.

j3r3m1 avatar Feb 23 '22 09:02 j3r3m1

It seems done ?

ebocher avatar Jun 15 '23 05:06 ebocher

No the idea was to simplify the code gathering indicator calculation by indicatorUse but finding a way to check that an indicator has been calculated to avoid double calculations when a same indicator is used in two indicatorUse

j3r3m1 avatar Jun 15 '23 14:06 j3r3m1