Oliver Beckstein
Oliver Beckstein
It would be great if someone here with access to a development environment on windows could dig into this issue. It looks as if the core developers are busy (and...
@richardjgowers / @hmacdope would one of you assign the PR to yourself to look after it? You both seem to have an interest in it.
## Testing Writing test takes some time to learn. We use [pytest](https://docs.pytest.org/en/stable/) as our testing framework so you may have to keep looking up things there. See https://userguide.mdanalysis.org/stable/testing.html#testing for more...
You should add your lammpsdump data file to the testsuite (see [develop/testsuite/MDAnalysisTests/datafiles.py](https://github.com/MDAnalysis/mdanalysis/blob/develop/testsuite/MDAnalysisTests/datafiles.py)). Make it as small as possible and bz2 compress it. Ideally, it should be much less than 1...
I am going to assign myself as PR shepherd but if anyone else wants to take over or be involved, please do!
Did you run black with version 24? (Check `black --version` and if necessary pin to 24)
If you look at https://github.com/MDAnalysis/mdanalysis/pull/5066/files you see that 260(!) files were changed. I would look into reverting the commit that did that. Alternatively, find the files where you definitely added...
The tests look ok to me. The black-formatting is a bit annoying as it takes up so much vertical space but I don't know how to change it and it's...
When you commit a suggestion, it is added to the branch on GitHub. You can then pull in these changes with `git pull`.
Your test file is not packaged, see **build_testsuite_sdist** in https://github.com/MDAnalysis/mdanalysis/actions/runs/16632261268/job/47064413158?pr=5066 YOu'll need to add a line in testsuite/pyproject.toml after https://github.com/MDAnalysis/mdanalysis/blob/96f0b67f97d23b11c3ea627ec491efe87b3c900a/testsuite/pyproject.toml#L118 like ``` "data/analysis/msd/*", ``` so that the files are included....